Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.28] Fix check python errors #6963

Merged
merged 2 commits into from
Jan 26, 2023
Merged

[Backport 2.28] Fix check python errors #6963

merged 2 commits into from
Jan 26, 2023
+4 −4

Conversation

davidhorstmann-arm
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm commented Jan 24, 2023 •
edited by paul-elliott-arm
Loading

Trivial backport of #6962.

Gatekeeper checklist

  • changelog provided, or not required
  • backport done, or not required
  • tests provided, or not required

Sorry, something went wrong.

@davidhorstmann-arm
Fix a missing type hint warning
4fc7e0e 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm
Give proper Dict type hints in crypto_knowledge.py
659d905 
This prevents a return type error in a later function that uses the
dictionaries here properly typed.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) single-reviewer This PR qualifies for having only one reviewer priority-low Low priority - this may not receive review soon labels Jan 24, 2023
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jan 24, 2023
Merged
3 tasks
@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 24, 2023
@davidhorstmann-arm davidhorstmann-arm removed the needs-ci Needs to pass CI tests label Jan 26, 2023
@gilles-peskine-arm gilles-peskine-arm merged commit 0f16ce0 into Mbed-TLS:mbedtls-2.28 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm

Assignees
No one assigned
Labels
priority-low Low priority - this may not receive review soon single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidhorstmann-arm @gilles-peskine-arm