Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Fix name of basic build test.sh 2.28 #6695

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Backport 2.28: Fix name of basic build test.sh 2.28 #6695

merged 1 commit into from
Nov 30, 2022
+2 −2

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented Nov 30, 2022 •
edited by gilles-peskine-arm
Loading

basic-build-test.sh calls itself basic-build-tests.sh internally, which is wrong, so fix it.

Gatekeeper checklist

Sorry, something went wrong.

@tom-cosgrove-arm
Fix the name of basic-build-test.sh within the file
5f49b3c 
Signed-off-by: Tom Cosgrove <tom.cosgrove@arm.com>
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Nov 30, 2022
Merged
3 tasks
@tom-cosgrove-arm tom-cosgrove-arm added the single-reviewer This PR qualifies for having only one reviewer label Nov 30, 2022
gilles-peskine-arm
gilles-peskine-arm approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added the approved Design and code approved - may be waiting for CI or backports label Nov 30, 2022
@gilles-peskine-arm gilles-peskine-arm merged commit 3917028 into Mbed-TLS:mbedtls-2.28 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tom-cosgrove-arm @gilles-peskine-arm