2.28 compat.sh: Restore testing against OpenSSL for pre 1.2 TLS versions #6654
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore compatibiltiy testing against OpenSSL for (D)TLS versions smaller that 1.2. . Fix the check for support in OpenSSL for these versions . For test cases for (D)TLS version smaller than 1.2, restore the configuration of OpenSSL client/server with the given TLS version, as it was before Mbed-TLS#5660 that broke it. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
ronald-cron-arm
changed the title
ronald-cron-arm
added
bug
component-tls
needs-ci
ronald-cron-arm
added
needs-review
gilles-peskine-arm
approved these changes
Nov 24, 2022
3 tasks
mpg
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #6650
I've done some checks of the number of tests: full configuration + OpenSSL 1.0.2g.
./tests/compat.sh -p OpenSSL -m "ssl3 tls1 tls1_1 dtls1":
. mbedtls-2.28 + this PR: 232 tests 2 skipped
. mbedtls-2.28.0: 232 test 2 skipped
./tests/compat.sh
. mbedtls-2.28 + this PR: 1984 tests 4 skipped
. mbedtls-2.28.0: 856 tests 2 skipped
Much more tests now because of #5660 I think.
Gatekeeper checklist