Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pr template - 2.28 backport #6527

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Update pr template - 2.28 backport #6527

merged 5 commits into from
Nov 2, 2022
+20 −30

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented Nov 1, 2022 •
edited
Loading

Almost trivial backport of #6514.

This PR makes CONTRIBUTING.md and .github/pull_request_template.md identical to the copies in the development branch.

Changelog: not needed

@daverodgman
Update PR template
f1d74ac 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Update CONTRIBUTING.md, and refer to this from the template
53b65f6 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Reinstate note about all PRs receiving review
9a1c38a 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Improve list formatting
bc1e670 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Align CONTRIBUTING.md with development
d39cf1e 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman added enhancement needs-review Every commit must be reviewed by at least two team members, component-docs Docs / website issues filed here for tracking needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) single-reviewer This PR qualifies for having only one reviewer priority-medium Medium priority - this can be reviewed as time permits labels Nov 1, 2022
@daverodgman daverodgman mentioned this pull request Nov 1, 2022
Merged
@daverodgman daverodgman removed the needs-reviewer This PR needs someone to pick it up for review label Nov 1, 2022
gilles-peskine-arm
gilles-peskine-arm approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a faithful backport. The GitHub templates aren't used outside the default branch, but it doesn't hurt to have them.

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports and removed single-reviewer This PR qualifies for having only one reviewer labels Nov 2, 2022
@daverodgman daverodgman added the single-reviewer This PR qualifies for having only one reviewer label Nov 2, 2022
@daverodgman daverodgman merged commit e43caca into Mbed-TLS:mbedtls-2.28 Nov 2, 2022
@daverodgman daverodgman deleted the update_pr_template-2.28 branch November 2, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm

@paul-elliott-arm paul-elliott-arm

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-docs Docs / website issues filed here for tracking enhancement needs-review Every commit must be reviewed by at least two team members, priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daverodgman @gilles-peskine-arm