Skip to content

Upgrade js-yaml #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Upgrade js-yaml #235

merged 2 commits into from
Jun 7, 2021

Conversation

wparad
Copy link
Contributor

@wparad wparad commented Jun 5, 2021

No description provided.

@philsturgeon philsturgeon enabled auto-merge June 7, 2021 17:14
@philsturgeon
Copy link
Member

Sorry I'm trying to figure out the problems with GitHub Actions, I might have just done it, but we've got some conflicts now. Could you have a look?

auto-merge was automatically disabled June 7, 2021 17:45

Head branch was pushed to by a user without write access

@wparad wparad force-pushed the upgrade-js-yaml branch from 7dff353 to 20192cd Compare June 7, 2021 17:45
@wparad
Copy link
Contributor Author

wparad commented Jun 7, 2021

@philsturgeon, the CI-CD.yml was missing a pull_request: I've fixed it, but I need someone to allow running them before they'll trigger.

@philsturgeon philsturgeon enabled auto-merge June 7, 2021 17:58
@philsturgeon
Copy link
Member

Thank you! I just landed on that same conclusion myself #238 🤣 Will merge yours as soon as its done.

auto-merge was automatically disabled June 7, 2021 18:03

Head branch was pushed to by a user without write access

@wparad wparad force-pushed the upgrade-js-yaml branch 2 times, most recently from 5e0e6a2 to 20192cd Compare June 7, 2021 18:05
@wparad wparad force-pushed the upgrade-js-yaml branch from 20192cd to 61c9d17 Compare June 7, 2021 18:07
@wparad
Copy link
Contributor Author

wparad commented Jun 7, 2021

yikes, npm run test worked on my machine ;)

DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.2 LTS"

GithubAction:

TOTAL: 492 SUCCESS

=============================== Coverage summary ===============================
Statements   : 92.47% ( 811/877 )
Branches     : 85.68% ( 395/461 )
Functions    : 94.81% ( 128/135 )
Lines        : 92.5% ( 802/867 )
================================================================================

=============================== Coverage summary ===============================
Statements   : 92.47% ( 811/877 )
Branches     : 85.68% ( 395/461 )
Functions    : 94.81% ( 128/135 )
Lines        : 92.5% ( 802/867 )
================================================================================
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @apidevtools/json-schema-ref-parser@0.0.0-dev test:browser: `karma start --single-run "--coverage"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @apidevtools/json-schema-ref-parser@0.0.0-dev test:browser script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2021-06-07T18_19_45_565Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @apidevtools/json-schema-ref-parser@0.0.0-dev coverage:browser: `npm run test:browser -- --coverage`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @apidevtools/json-schema-ref-parser@0.0.0-dev coverage:browser script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2021-06-07T18_19_45_585Z-debug.log
Error: Process completed with exit code 1.

@wparad
Copy link
Contributor Author

wparad commented Jun 7, 2021

Are secrets available in PR jobs?

      - name: Run tests
        run: npm run coverage:browser
        env:
          SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
          SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}

@philsturgeon philsturgeon enabled auto-merge June 7, 2021 18:18
@wparad
Copy link
Contributor Author

wparad commented Jun 7, 2021

Is this the problem:
image

@philsturgeon philsturgeon merged commit 7a899bc into APIDevTools:main Jun 7, 2021
@philsturgeon
Copy link
Member

Got it! I dont know what's been going on around here but there's a few problems that need fixing. I'll get things sorted out when I dont feel like I'm dying! :D Thanks for your patience.

@wparad wparad deleted the upgrade-js-yaml branch June 7, 2021 18:35
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

🎉 This PR is included in version 9.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants