Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests #461

Closed
cookpa opened this issue May 16, 2023 · 8 comments
Closed

Failing tests #461

cookpa opened this issue May 16, 2023 · 8 comments

Comments

@cookpa
Copy link
Member

cookpa commented May 16, 2023

Hi @ntustison ,

Lots of test failures on the most recent PR.

https://github.com/ANTsX/ANTsPy/actions/runs/4969163765/jobs/8892176590

Errors about transform factories - do you think these could be related to the recent troubles with ANTsR? But I don't get why this is suddenly a thing. The runners should be the same since the switch to Ubuntu 22.04 in October 2022 (actions/runner-images#6399). The ANTs version has not changed since #442. But there are some settings in the runners that might change. I'll see what I can do to help lock those down.

Did your recent PR build successfully on your machine? Would you mind sharing the details of what system, compiler you used?

@ntustison
Copy link
Member

No, I'm pretty sure this stems from this commit from @richardbeare which expands template building to include the linear averaging step. The problem is that the original code from Gang uses the MatrixOffsetTransformBase class which, I learned from Hans a long time ago, was never meant to actually be used which is why it's not registered with the other transform factories. So it's unrelated but it still needs to get fixed. I'll try to look at it later.

@ntustison
Copy link
Member

I think it's here. Let me see if that fixes it.

@ntustison
Copy link
Member

#462

@cookpa
Copy link
Member Author

cookpa commented May 16, 2023

Thanks - hopefully that does it

@ntustison
Copy link
Member

Closing as it looks like the PR fixed the issue. Thanks @cookpa .

@cookpa
Copy link
Member Author

cookpa commented May 16, 2023

Thanks! FYI Windows tests always pass, they need some additional coding to exit with failure. But everything looks good now.

@richardbeare
Copy link

Sorry! 🤦

@cookpa
Copy link
Member Author

cookpa commented May 17, 2023

Sorry! 🤦

It's all good - thanks for the new functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants