Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Assert causing INTERNALERROR in pytest 6.0.0 #474

Closed
parijatm opened this issue Sep 2, 2020 · 5 comments
Closed

Bug: Assert causing INTERNALERROR in pytest 6.0.0 #474

parijatm opened this issue Sep 2, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@parijatm
Copy link
Collaborator

parijatm commented Sep 2, 2020

Issue:
Upgrading to pytest version 6.0.0 breaks nightly regressions by causing INTERNALERROR upon encountering failed DRC checks. This error causes the overall regression to silently pass without running all circuits.

Temporary fix:
I have forced our Docker build environment to explicitly use pytest version 5.4.3 (#473). We should upgrade to pytest 6.0.0 and fully root-cause the INTERNALERROR issue at some point.

@parijatm
Copy link
Collaborator Author

parijatm commented Sep 2, 2020

I have root-caused the INTERNALERROR to a pytest bug that is exercised when you generate junit.xml and use --tb=line.

Can we drop the --tb=line? Tagging both @kkunal1408 @stevenmburns since I am not sure who added it.

The other option would be to leave it as it is now (use version 5.4.3) and await a pytest fix.

@parijatm
Copy link
Collaborator Author

parijatm commented Sep 3, 2020

Also filed pytest-dev/pytest#7707

@kkunal1408
Copy link
Collaborator

I added the tb=line so that only the DRCs count gets populated when the assert statement for DRC count=0 fails. Without this command, it dumps a long log (terminating after a fixed length) instead of a concise view thus affecting the readability of the report.

@parijatm
Copy link
Collaborator Author

parijatm commented Sep 3, 2020

Got it. Let's stick with pytest 5.4.3 until we get a 6.0 fix in that case.

The bug has been acknowledged and is being addressed in an active pull request.

@parijatm parijatm changed the title Use pytest 6.0.0 Bug: Assert causing INTERNALERROR in pytest 6.0.0 Sep 3, 2020
@parijatm parijatm self-assigned this Sep 3, 2020
@parijatm parijatm added the bug Something isn't working label Sep 3, 2020
This was referenced Sep 19, 2020
@parijatm
Copy link
Collaborator Author

Bug has been addressed in pytest 6.0.2. ALIGN will be contoured with latest pytest once PR #449 is merged with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants