New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Assert causing INTERNALERROR in pytest 6.0.0 #474
Comments
I have root-caused the INTERNALERROR to a pytest bug that is exercised when you generate junit.xml and use --tb=line. Can we drop the --tb=line? Tagging both @kkunal1408 @stevenmburns since I am not sure who added it. The other option would be to leave it as it is now (use version 5.4.3) and await a pytest fix. |
Also filed pytest-dev/pytest#7707 |
I added the tb=line so that only the DRCs count gets populated when the assert statement for DRC count=0 fails. Without this command, it dumps a long log (terminating after a fixed length) instead of a concise view thus affecting the readability of the report. |
Got it. Let's stick with pytest 5.4.3 until we get a 6.0 fix in that case. The bug has been acknowledged and is being addressed in an active pull request. |
Bug has been addressed in pytest 6.0.2. ALIGN will be contoured with latest pytest once PR #449 is merged with master. |
Issue:
Upgrading to pytest version 6.0.0 breaks nightly regressions by causing INTERNALERROR upon encountering failed DRC checks. This error causes the overall regression to silently pass without running all circuits.
Temporary fix:
I have forced our Docker build environment to explicitly use pytest version 5.4.3 (#473). We should upgrade to pytest 6.0.0 and fully root-cause the INTERNALERROR issue at some point.
The text was updated successfully, but these errors were encountered: