Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Need to add uap10.0.17763 target to PCLCrypto #152

Closed
AArnott opened this issue Aug 18, 2020 · 3 comments
Closed

Need to add uap10.0.17763 target to PCLCrypto #152

AArnott opened this issue Aug 18, 2020 · 3 comments
Assignees
Labels

Comments

@AArnott
Copy link
Owner

AArnott commented Aug 18, 2020

6 UAP tests in the solution throw NotImplementedByReferenceAssemblyException because UAP consumes the netstandard2.0 build of the library instead of a build of the library that contains UAP-specific code.

See novotnyllc/MSBuildSdkExtras#237 for tracking issue.

@AArnott AArnott added the bug label Aug 18, 2020
@AArnott AArnott self-assigned this Aug 18, 2020
@1Cor125
Copy link

1Cor125 commented Apr 28, 2021

Any update on this issue @AArnott ? We are looking forward to taking the 2.1 update on an app we have that runs on Android, iOS and UWP. Currently we have branching logic on the UWP since the OOB dotnet crypto is actually a little faster than the WinRT implementation.

@AArnott
Copy link
Owner Author

AArnott commented Apr 28, 2021

the OOB dotnet crypto

What is that?

I haven't had time to spend on it yet. Not likely to for the next month or so either.
I will say that targeting uap is often problematic. So if you'd like to try your hand at it, you're welcome to it if it's simple. If it's a lot of code changes, I think we should wait till my renovate branch merges to avoid a lot of merge conflicts.

@1Cor125
Copy link

1Cor125 commented Apr 29, 2021

Sorry @AArnott , by "OOB dotnet crypto", I meant the out of the box System.Security.Cryptography API that is included in the netstandard2 contract.

I will check out main and see if I can get my bearings. Thanks.

@AArnott AArnott closed this as completed Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants