fix(kwallet): empty wallet key query #87
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying a key in an empty kwallet wallet, we receive the following error: ``` Error: unexpected end of JSON input ``` This is because the `k.wallet.ReadEntry` returns empty bytes and no error. Hence we should handle a case for empty bytes. Reference: cosmos/cosmos-sdk#9562
4 tasks
|
@robert-zaremba can you please add tests? |
rootulp
added a commit
to rootulp/cosmos-sdk
that referenced
this pull request
Jul 14, 2022
The `replace` for 99designs/keyring to a Cosmos fork of keyring (cosmos/keyring) was added in cosmos#9563 Removal of the `replace` was tracked in cosmos#9568 but never completed. The original issue was fixed in upstream: 99designs/keyring#87 so this PR removes the `replace` and upgrades to the latest release of 99designs/keyring.
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying a key in an empty kwallet wallet, we receive the following error:
This is because the
k.wallet.ReadEntryreturns empty bytes and no error. Hence we should handle a case for empty bytes.Reference: cosmos/cosmos-sdk#9562