dashes in secret service backend break roundtrip (fix #82) #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leejw51crypto
force-pushed
the
gnome
branch
2 times, most recently
from
34f7c95
to
997bc31
Compare
tomtau
reviewed
Mar 31, 2021
| @@ -56,6 +59,28 @@ func (e *secretsError) Error() string { | |||
|
|
|||
| var errCollectionNotFound = errors.New("The collection does not exist. Please add a key first") | |||
|
|
|||
| func decodeKeyringString(src string) string { | |||
There was a problem hiding this comment.
Seems like a good function to have some unit tests for ;)
There was a problem hiding this comment.
ok, i'll add unit test
|
|
remove debug code tidy up remove un-necessary condition add unit test
|
add unit test |
tomtau
approved these changes
Apr 22, 2021
4 tasks
|
Is #90 doing something similar? |
|
Yes, it is |
|
@tomtau which approach is better? |
|
#90 may be simpler (it encodes the provided secret path once, while this PR attempts to decode every retrieved path in collections) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix reading in gnome keyring