Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RSA signing #34

Open
aaronpk opened this issue Jul 2, 2018 · 3 comments
Open

Support RSA signing #34

aaronpk opened this issue Jul 2, 2018 · 3 comments

Comments

@aaronpk
Copy link

aaronpk commented Jul 2, 2018

It looks like this library currently only supports HMAC signing. It would be great if it also supported RSA signing with a private key!
@liamdennehy
Copy link
Contributor

liamdennehy commented Aug 17, 2018 •
edited

PR #35 implements RSA signing

  • Supports SHA256 (you really shouldn't be implementing anything new on SHA1)
  • Tested against servers enforcing Signature & Authorization headers
  • Does not contain unit tests, but with some pointers I am sure this can be completed.

@liamdennehy liamdennehy mentioned this issue Oct 12, 2018
Open
@liamdennehy
Copy link
Contributor

Update: #35 Has full suite of unit tests, and in combination with #43 now passes the Reference Tests.

@liamdennehy
Copy link
Contributor

I have integrated RSA in my own project along with a number of others (Elliptic curves, DSA) that can pass the RFC reference tests, and published this in packagist. Documentation for the entire library is published at Read the Docs: http-signatures-php - incomplete but being expanded regularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronpk @liamdennehy