Skip to content

@goTag do not override existing tag #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
valllabh opened this issue Jan 22, 2023 · 1 comment · Fixed by #2533
Closed

@goTag do not override existing tag #2514

valllabh opened this issue Jan 22, 2023 · 1 comment · Fixed by #2533

Comments

@valllabh
Copy link
Contributor

valllabh commented Jan 22, 2023 •
edited
Loading

@goTag do not override existing tag

Ideally it should override existing tag. sole purpose of the directive is to give control to user.
Looks

image

image

GoTagFieldHook just appends new tags

gqlgen/plugin/modelgen/models.go

Line 415 in 866187f

f.Tag = f.Tag + " " + strings.Join(args, " ")

@valllabh valllabh changed the title @goTag does not override existing tag @goTag do not override existing tag Jan 25, 2023
This was referenced Jan 27, 2023
Closed
Closed
@StevenACoffman StevenACoffman mentioned this issue Jan 27, 2023
Merged
StevenACoffman added a commit that referenced this issue Jan 27, 2023
@StevenACoffman @valllabh
prepend goTag directive on struct tags and omit overridden duplicate …

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
356f4f9 
…struct tags per #2514 (#2533)

* removeDuplicateTags func introduced to fix #2514

* Change to prepend goTag directive

Signed-off-by: Steve Coffman <steve@khanacademy.org>

* Fix test for field_hooks_are_applied to prepend

Signed-off-by: Steve Coffman <steve@khanacademy.org>

---------

Signed-off-by: Steve Coffman <steve@khanacademy.org>
Co-authored-by: vallabh <vallabh.joshi@gmail.com>
@StevenACoffman
Copy link
Collaborator

Thanks for reporting this!

@valllabh valllabh mentioned this issue Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@valllabh @StevenACoffman