Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagram in documentation #2381

Merged
merged 1 commit into from Sep 17, 2022
Merged

Update diagram in documentation #2381

merged 1 commit into from Sep 17, 2022

Conversation

bcspragu
Copy link
Contributor

@bcspragu bcspragu commented Sep 16, 2022

The diagram wasn't rendering properly in Go docs, which was a shame because it's a great diagram. This PR fixes that by indenting it another space.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

Before and after:
Screenshot 2022-09-16 at 15-58-28 graphql - Go Documentation Server

Screenshot 2022-09-16 at 15-58-49 graphql - Go Documentation Server

The diagram wasn't rendering properly in Go docs, which was a shame because it's a great diagram. This PR fixes that by indenting it another space.
@bcspragu bcspragu marked this pull request as ready for review September 16, 2022 23:00
@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.452% when pulling 6c1f326 on bcspragu:bcspragu/doc-update into 6bb3186 on 99designs:master.

@StevenACoffman StevenACoffman merged commit 68136ff into 99designs:master Sep 17, 2022
@StevenACoffman
Copy link
Collaborator

Thanks!

@bcspragu bcspragu deleted the bcspragu/doc-update branch September 17, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants