Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field merging behavior for fragments on interfaces #2380

Conversation

kxfang
Copy link
Contributor

@kxfang kxfang commented Sep 16, 2022

This PR fixes #2379 . The cause appears to be that when merging fields from a fragment spread, the interface equality check needs to be done in both directions, but is only done in one direction in the existing code.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 75.465% when pulling 4a490b4 on kxfang:kfang/fix_fragment_on_interface_field_merging into 6bb3186 on 99designs:master.

@StevenACoffman StevenACoffman merged commit d29d098 into 99designs:master Sep 17, 2022
@StevenACoffman
Copy link
Collaborator

Thanks very much for this!

@kxfang
Copy link
Contributor Author

kxfang commented Sep 18, 2022

@StevenACoffman I’m glad I could contribute! Any chance of a release in the next day or two?

@davidbyttow
Copy link

Thank you @StevenACoffman! (and Kev) ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when merging fields from a fragment on an interface
4 participants