Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field 'pullRequest' as pull request title, number with link #164

Merged
merged 7 commits into from Nov 12, 2021

Conversation

nowsprinting
Copy link
Contributor

@nowsprinting nowsprinting commented Oct 21, 2021

Add field pullRequest as pull request title, number with link.

Motivation:
When triggered with pull request event, the commit is the SHA of the merge commit, and the message is "HEAD into BASE".
I can trace the pull request page from job or workflow, but it would be nice to be able to refer to the pull request directly.

Note:
When it is triggered by push event, this field shows "n/a".

Discussions:
Which is the best format for the pullRequest field?
Current: <url | title #numer>
Alternative: title <html_url | #numer>

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #164 (83b844f) into master (2d3cbaf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          209       217    +8     
  Branches        54        56    +2     
=========================================
+ Hits           209       217    +8     
Impacted Files Coverage Δ
src/fields.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3cbaf...83b844f. Read the comment docs.

@nowsprinting
Copy link
Contributor Author

Sorry, I forget trigger events below:

  • pull_request_review
  • pull_request_review_comment
  • pull_request_target

I fix soon. plz wait.

@nowsprinting nowsprinting marked this pull request as draft October 25, 2021 08:27
Add support variations:

- pull_request_review
- pull_request_review_comment
- pull_request_target
@nowsprinting
Copy link
Contributor Author

Fixed event variation problem.
And add discussion in descriptions.

@nowsprinting nowsprinting marked this pull request as ready for review October 25, 2021 23:02
@8398a7
Copy link
Owner

8398a7 commented Oct 29, 2021

Thanks for the PR.

Which is the best format for the pullRequest field?
Current: <url | title #numer>
Alternative: title <html_url | #numer>

I prefer <url | title #numer>.

@nowsprinting
Copy link
Contributor Author

Thanks!

I prefer <url | title #numer>.

It's the current format.

Copy link
Owner

@8398a7 8398a7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to submit review.

docs/content/fields.md Show resolved Hide resolved
@8398a7 8398a7 merged commit a3e8b83 into 8398a7:master Nov 12, 2021
@8398a7
Copy link
Owner

8398a7 commented Nov 12, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants