Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .inputs.github_token.required (true -> false) #148

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

autopp
Copy link
Contributor

@autopp autopp commented Jul 23, 2021

This PR changes action.yml's .inputs.github_token.required to false

action.yml declares that github_token is required, but it seems to be optional.
(In my environment, it makes wrong error message by VSCode extension)

image

@autopp autopp changed the title Fix require of .inputs.github_token (false -> true) Fix .inputs.github_token.required (false -> true) Jul 23, 2021
@autopp autopp changed the title Fix .inputs.github_token.required (false -> true) Fix .inputs.github_token.required (true -> false) Jul 23, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #148 (12c3411) into master (6c319ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          161       161           
  Branches        34        34           
=========================================
  Hits           161       161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c319ca...12c3411. Read the comment docs.

@8398a7 8398a7 merged commit f71f6dd into 8398a7:master Jul 23, 2021
@autopp autopp deleted the fix-input-github_token branch July 24, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants