Add ability to get it working with proxy #144
Merged
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@8398a7 can you please take a look at this PR? |
Closed
|
@sethumadhav07 Sorry for the late confirmation. |
# Conflicts: # package-lock.json # package.json
|
@8398a7 can you please take a look at it and approve? |
8398a7
requested changes
Aug 15, 2021
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 204 209 +5
Branches 50 52 +2
=========================================
+ Hits 204 209 +5
Continue to review full report at Codecov.
|
|
CI is failing due to reduced test coverage. Can you please fix it? |
|
I fixed the code coverage for tests. can you please take a look at it and approve? |
8398a7
approved these changes
Sep 21, 2021
|
@8398a7 can a new release/tag be created that involves this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently slack connection using webhook is not working with proxy which is a common requirement in many corporate settings.
Code change in this PR addresses that.