Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fields): add job not found messaging to AS_TOOK #141

Merged
merged 1 commit into from
May 22, 2021

Conversation

Ignigena
Copy link
Contributor

I was experiencing issues in my workflow where process.env.AS_TOOK was coming through as undefined. This was not a matrix build or anything special, and I was only specifying this field to be added alongside a custom payload.

Turns out I had not specified the job_name since I had customized it in the workflow. I only found this out after looking through the code and realizing there's a nice helpful debug message pointing to the documentation 馃槃

Although, as it turns out, this debug message was being assigned to the wrong process.env variable. I was only using took and it was getting written to process.env.AS_JOB.

Since the same message is already attached to the correct env variable in this.job(), I've simply changed .took() to use AS_TOOK. Now, you'll see the same helpful debug message rather than just undefined if you haven't configured things quite right in the workflow.

@8398a7 8398a7 self-requested a review May 15, 2021 08:48
@8398a7
Copy link
Owner

8398a7 commented May 15, 2021

Thank you for the fix.
Your change looks correct. Please give me some time to check.

@8398a7 8398a7 merged commit 6c319ca into 8398a7:master May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants