Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KtField css rethink: use templates #829

Open
carsoli opened this issue Nov 9, 2023 · 0 comments
Open

KtField css rethink: use templates #829

carsoli opened this issue Nov 9, 2023 · 0 comments
Labels
package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon type:enhancement features, etc.

Comments

@carsoli
Copy link
Contributor

carsoli commented Nov 9, 2023

Use scss templates instead of having the KtField controll all the styles through the <KtField /> component.

Problem:

  • Having all the styles on KtField makes it hard to refactor or touch on those classes without breaking a component that tries to reuse the class
  • Fields can easily extend those templates & customize rather than reuse the classes (which is hacky)
@carsoli carsoli added type:enhancement features, etc. priority:3-normal Should be fixed soon package:kotti-ui @3yourmind/kotti-ui labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:kotti-ui @3yourmind/kotti-ui priority:3-normal Should be fixed soon type:enhancement features, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carsoli