Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support data-tests uniquely on KtFilters #679

Open
carsoli opened this issue Nov 22, 2022 · 0 comments
Open

support data-tests uniquely on KtFilters #679

carsoli opened this issue Nov 22, 2022 · 0 comments
Labels
priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs type:enhancement features, etc.

Comments

@carsoli
Copy link
Contributor

carsoli commented Nov 22, 2022 •
edited

Support data-test on each kt-filter__row to be split between column, operator, value
(enable somehow controlling the formId on the KtForm in FilterRow.vue)

we want to guarantee that each option in the columns select has a unique support of data-test
we therefore need to expose formId for the options so that it's not auto-ge
Screenshot from 2022-11-22 14-55-20
@carsoli carsoli added type:enhancement features, etc. priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:4-high ⚠️ Needs to be fixed ASAP, but without HACKs type:enhancement features, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@santiagoballadares @carsoli @Juli0GT