Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.x compatibility #18

Open
bytehead opened this issue Nov 2, 2021 · 8 comments
Open

PHP 8.x compatibility #18

bytehead opened this issue Nov 2, 2021 · 8 comments
Assignees

Comments

@bytehead
Copy link
Member

bytehead commented Nov 2, 2021

Raise PHP requirement to 7.4

@bytehead bytehead self-assigned this Nov 2, 2021
@bytehead bytehead changed the title PHP-8 compatibility PHP 8.x compatibility Nov 2, 2021
@contaoacademy
Copy link

Is this extension compatible with Contao 4.13 and PHP 8.2?

@bytehead
Copy link
Member Author

I don't know yet. But I can make it compatible 👍

@contaoacademy
Copy link

Maybe it would also be an idea to make one out of this and your extension ;-)

@bytehead
Copy link
Member Author

I don't know the other one - what's the difference?

@contaoacademy
Copy link

I can check the differences for you. However, I don't have the time at the moment. I'll make a note of it and get back to you.

@contaoacademy
Copy link

I am using your extension with Contao 4.13 and PHP 8.2. Runs perfectly so far. The ticket can therefore be closed.

Unfortunately, I don't have time to continue pursuing the topic of merging with the other extension.

@bytehead
Copy link
Member Author

Will update this extension to a bundle anyway with the next proper update.

@contaoacademy
Copy link

Now I have found a problem after all. When I activate the debug mode.
see: #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants