Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated global Twig functions #366

Merged
merged 2 commits into from Feb 5, 2020

Conversation

KoenvanWijnen
Copy link
Contributor

Updated the UploaderExtension so it's supports Twig 3.0.
Also had to add Twig to the composer requirement because it was not there yet.

@Holicz
Copy link

Holicz commented Dec 30, 2019

Is anything blocking the merge of this PR? I am ready to help.

@bytehead
Copy link
Member

The tests are failing, I've to check this first. I don't know if it's related to this changes.

@bytehead
Copy link
Member

@Holicz I've looked into the tests. They're failing because of Symfony > 4.1, see also #364.

@bytehead
Copy link
Member

bytehead commented Feb 4, 2020

@KoenvanWijnen can you rebase your PR with the actual master? It possibly fixes the tests. :-)

@KoenvanWijnen
Copy link
Contributor Author

KoenvanWijnen commented Feb 5, 2020

@KoenvanWijnen can you rebase your PR with the actual master? It possibly fixes the tests. :-)

All done and thanks for the reminder!

@bytehead
Copy link
Member

bytehead commented Feb 5, 2020

Looks good! 🎉

@bytehead bytehead merged commit 0127666 into 1up-lab:master Feb 5, 2020
@bytehead
Copy link
Member

bytehead commented Feb 5, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants