Deprecation removal Symfony 4.2 #357
Merged
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can we please merge this? |
|
Sure, 2.1.2 is just released! Thanks @Wait4Code 👍 |
neoantox
reviewed
Apr 5, 2019
| @@ -20,7 +30,6 @@ protected function configure() | |||
|
|
|||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| $manager = $this->getContainer()->get('oneup_uploader.orphanage_manager'); | |||
| $manager->clear(); | |||
| @@ -20,7 +30,6 @@ protected function configure() | |||
|
|
|||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| $manager = $this->getContainer()->get('oneup_uploader.chunk_manager'); | |||
| $manager->clear(); | |||
| /** @var ChunkManager */ | ||
| protected $manager; | ||
|
|
||
| public function __construct(ChunkManager $manager, ?string $name = null) |
There was a problem hiding this comment.
New argument was introduced. It should be passed to command in Resources/config/uploader.xml.
| /** @var OrphanageManager */ | ||
| protected $manager; | ||
|
|
||
| public function __construct(OrphanageManager $manager, ?string $name = null) |
There was a problem hiding this comment.
New argument was introduced. It should be passed to command in Resources/config/uploader.xml.
|
@bytehead, please take a look |
|
Oops, I'll recheck! |
|
Indeed, my pull-request breaks theses 2 commands. My bad. I've done needed changes locally. I can provide a new pull request if needed. |
|
No worries, I'm just finishing the fix. 🙂 |
|
2.1.3 should fix it! thanks @neoantox for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContainerAwareCommand is deprecated since Symfony 4.2. I just replaced it by Command service and then use dependency injection in command controller to make use of ChunkManager or OrphanageManager instead of getting it by container get method.
Fix #354