Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange the options array #44

Open
yellow1912 opened this issue Feb 4, 2015 · 1 comment
Open

Rearrange the options array #44

yellow1912 opened this issue Feb 4, 2015 · 1 comment

Comments

@yellow1912
Copy link
Contributor

Right now we are configuring the system like this:

filesystems:
        s3_lib:
            adapter: s3_lib
            visibility: public
            cache: local

Then in the DI Extension we have to check manually:

$options = [];
        if (array_key_exists('visibility', $config)) {
            $options['visibility'] = $config['visibility'];
        }

This will get troublesome later when new options are available etc. I suggest we change it to this:

filesystems:
        s3_lib:
            adapter: s3_lib
            options:
                visibility: public
            cache: local

We can then easily use $config['options'] array in our DI Extension.

@sheeep
Copy link
Contributor

sheeep commented Feb 4, 2015

Indeed. visibility seems to be given to the filesystem as an element in an option array, so this definitely makes sense to me.

@sheeep sheeep added this to the Version 1.0 milestone Feb 4, 2015
@bytehead bytehead removed this from the Version 1.0 milestone Jan 7, 2016
@bytehead bytehead added this to the 2.0.0 milestone May 15, 2017
@bytehead bytehead removed this from the 2.0.0 milestone Jun 19, 2017
@bytehead bytehead modified the milestone: 2.0.0 Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants