Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio-util dependency #273

Closed
ljedrz opened this issue Apr 22, 2022 · 7 comments
Closed

Update tokio-util dependency #273

ljedrz opened this issue Apr 22, 2022 · 7 comments

Comments

@ljedrz
Copy link

ljedrz commented Apr 22, 2022

Is this repository still maintained? I forked it, as I needed current tokio-util in order for it to work with my project, but I wonder if the current inactivity is temporary or not. There aren't any extra features I'm currently interested in, so I'm talking about passive maintenance (updating deps, bugfixes).

@1tgr
Copy link
Owner

1tgr commented Apr 22, 2022

I haven't been clicking the button that merges Dependabot's PRs that update dependencies, but if you have a PR I'd be happy to merge it into this repo.

As it happens I'm away from day-to-day Rust development but I'm happy to step in as needed.

@ljedrz
Copy link
Author

ljedrz commented Apr 22, 2022

I just checked and #270 (which also covers #259) is basically all I'd need right now; not sure why 2 CI jobs are failing there, are they perhaps flaky or is there anything that would require some extra work?

@1tgr
Copy link
Owner

1tgr commented Apr 24, 2022

The error on integration testing is a connection reset at the end, which I've seen before sometimes. The error went away on a rerun.

The error on fuzz testing looks the same as signalapp/libsignal#378. Hopefully an update to the nightly toolchain will fix it, I'm trying it locally.

@1tgr 1tgr changed the title Maintenance status of the repository Update tokio-util dependency Apr 24, 2022
@1tgr
Copy link
Owner

1tgr commented Apr 24, 2022

Happy birthday!

@ljedrz
Copy link
Author

ljedrz commented Apr 25, 2022

Thanks, it looks like for the time being I can just depend on the master branch of the repo now, which is totally fine for me 👌.

@ljedrz ljedrz closed this as completed Apr 25, 2022
@1tgr
Copy link
Owner

1tgr commented Apr 25, 2022

On second thoughts, I'll update the crates to reference tokio-util >= 0.6, thereby allowing 0.6 or 0.7 (or 0.8 etc). The repo builds fine with either version, although I notice tokio-util adds tokio-rs/tokio#4427 which I asked for a while back.

@ljedrz
Copy link
Author

ljedrz commented Apr 26, 2022

Thanks for the release, 0.5.1 works just fine with my project now 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants