-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepend arg for defaults-file #408
base: main
Are you sure you want to change the base?
Conversation
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
Added my GPG key to Github -- commits are signed |
46ce3d1
to
e45e42f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Any chance to get this approved and released ? The plugin is otherwise broken for all but the simplest usecases. |
@AndyTitu can you help with getting a second approver? Any chance you could add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prepending appears a reasonable and pragmatic approach.
Any maintainers able to merge to get this officially into next 1password-cli release ? |
@SimonBarendse this seems ready to go. Can you provide guidance if there are any steps missing? |
Overview
The
mysql
CLI depends on the--defaults-file=foo
argument being the very first argument. This change provides a new 'PrependArgs' method and uses it for themysql
plugin.From the
mysql
CLI help text:Type of change
Related Issue(s)
How To Test
Build the plugin locally and run
op plugin run mysql -- --host=foo
using a credential with nohost
field. Before this PR, it results in the error:mysql: [ERROR] unknown variable 'defaults-file=...
because the MySQL treats unknown arguments in the form--variable-name=foo
as MySQL configuration variable. After the PR, additional command-line arguments are appended after--defaults-file
that is injected by themysql
plugin.Changelog
mysql
CLI depends on the--defaults-file=foo
argument being the very first argument