Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew plugin does not provide shell-specific configuration instructions #357

Open
hakamadare opened this issue Jul 21, 2023 · 0 comments

Comments

@hakamadare
Copy link

Platform or tool

Homebrew

Desired or expected behavior

The plugin provides configuration information for zsh, even when my account's default shell is set to bash, and the current process is a bash instance.

$ ps
PID  TTY        TIME    CMD
1340 ttys000    4:34.85 bash (figterm)
1359 ttys001    0:00.43 /usr/local/Cellar/bash/5.2.15/bin/bash --login
...

In this case, I would have expected the documentation to look something like

The last step is to set up an alias for brew.
You can do so by running the following command:

  echo "source /Users/${USER}/.config/op/plugins.sh" >> ~/.profile && source ~/.profile

Afterwards, run any brew command to see it in action!

since my shell configuration is stored in ~/.profile; if the files ~/.bash_profile or ~/.bash_login were present, I would expect one of those to be interpolated, following the order of precedence in the bash man page:

  When bash is invoked as an interactive login shell, or as a non-interactive shell
  with the --login option, it first reads and executes commands from the file
  /etc/profile, if that file exists.  After reading that file, it looks for
  ~/.bash_profile, ~/.bash_login, and ~/.profile, in that order, and reads and
  executes commands from the first one that exists and is readable.

Current behavior

The current help output after configuring the plugin on my system looks like this:

The last step is to set up an alias for brew.
You can do so by running the following command:

  echo "source /Users/${USER}/.config/op/plugins.sh" >> ~/.zshrc && source ~/.zshrc

Afterwards, run any brew command to see it in action!

Relevant log output

No response

op CLI version

2.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@hakamadare and others