Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eleventy Serverless URLs with encoded characters fail to match on Netlify #2221

Closed
zachleat opened this issue Feb 17, 2022 · 1 comment
Closed

Eleventy Serverless URLs with encoded characters fail to match on Netlify #2221

zachleat opened this issue Feb 17, 2022 · 1 comment
Assignees
@zachleat
Labels
bug: environment Had a problem with a third party tool
Milestone
Eleventy 1.0.1

Comments

@zachleat
Copy link
Member

zachleat commented Feb 17, 2022 •
edited

On Netlify a request to /odb/%23ffffff/%23bc1a1a/ resulted in the event.path object having a value of "/odb/#ffffff/#bc1a1a/" resulting in a serverless 404 error

We should change the Eleventy Serverless default to use something like event.path = new URL(event.rawUrl).pathname instead.

As noticed by @jlengstorf and @BenDMyers on Learn with Jason today. Credit to @ascorbic for the recommended workaround.
@zachleat zachleat added the bug: environment Had a problem with a third party tool label Feb 17, 2022
@zachleat zachleat added this to the Eleventy 1.0.1 milestone Feb 17, 2022
@zachleat zachleat self-assigned this Feb 17, 2022
zachleat added a commit to 11ty/11ty-website that referenced this issue Feb 18, 2022
@zachleat
Workaround for 11ty/eleventy#2221
e15671d
zachleat added a commit to 11ty/11ty-website that referenced this issue Feb 18, 2022
@zachleat
Workaround for 11ty/eleventy#2221 that also works without that issue …
05c2182 
…being fixed upstream
@zachleat
Copy link
Member Author

Shipping with 1.0.1. Newest possible canary v1.0.1-canary.4

@zachleat zachleat mentioned this issue Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zachleat zachleat

Labels
bug: environment Had a problem with a third party tool
Projects
None yet
Milestone
Eleventy 1.0.1
Development

No branches or pull requests
1 participant
@zachleat