Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up colorize function #11

Closed
0x20F opened this issue Mar 2, 2020 · 2 comments
Closed

Speed up colorize function #11

0x20F opened this issue Mar 2, 2020 · 2 comments
Assignees
@0x20F
Labels
enhancement New feature or request refactor Simplify code, cleanup, or separate large structures/files

Comments

@0x20F
Copy link
Owner

0x20F commented Mar 2, 2020 •
edited

Maybe change name to colorise too
@0x20F 0x20F added the enhancement New feature or request label Mar 2, 2020
@0x20F 0x20F self-assigned this Mar 2, 2020
@0x20F 0x20F added the refactor Simplify code, cleanup, or separate large structures/files label Mar 2, 2020
@0x20F 0x20F closed this as completed Mar 2, 2020
@manio
Copy link
Contributor

manio commented Nov 12, 2021

Hi,
Did you maybe was thinking about the improvement in the paris which is mentioned in this comment?
Drakulix/simplelog.rs#87 (comment)
Is it hard to implement such API?

@0x20F
Copy link
Owner Author

0x20F commented Nov 13, 2021

Heya!

Should definitely be doable, although considering that something like this was never intended with the original design of the API it's something quite big to add now. I can't say for sure what (in the existing codebase) would need rewriting and/or extending.

It doesn't sound like a bad idea though, performance could definitely need some improvements in certain cases.
With that said you're more than welcome to open up a PR if you've got any direct ideas on how to implement this. If you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x20F 0x20F

Labels
enhancement New feature or request refactor Simplify code, cleanup, or separate large structures/files
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manio @0x20F