ID type should be string not string | number

[benjie]

Describe the bug

gql.tada specifies the default scalar ID as string | number:

gql.tada/src/introspection.ts

Lines 112 to 113 in e882036

	interface DefaultScalars {
	ID: number | string;

From the GraphQL Specification, 3.5.5 ID (emphasis mine):

The ID scalar type represents a unique identifier, often used to refetch an object or as the key for a cache. The ID type is serialized in the same way as a String; however, it is not intended to be human-readable. While it is often numeric, it should always serialize as a String.

I think this should should have been must, but the main point is an ID type should never come back from the server with typeof id === 'number', it will always be typeof id === 'string' (or null).

Reproduction

No response

gql.tada version

main branch

Validations

• I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
• Read the docs.
• Follow our Code of Conduct

[JoviDeCroock]

That's a good point, let's fix that!

[benjie]

I've raised an RFC PR to make this clearer: graphql/graphql-spec#1086